diff options
| author | silvinor | 2025-09-20 05:37:18 +0200 |
|---|---|---|
| committer | GitHub | 2025-09-20 05:37:18 +0200 |
| commit | a4b112b1efa1e47bf0cd7da7ffd2120e9dfb6ce0 (patch) | |
| tree | 5d6d2f3bea6ce9b24856bb9190dfefa066bc5e8a | |
| parent | d1b0397d2f596bf9d87ec21745ead1410a6cd023 (diff) | |
[keyboard] Binepad KnobX1 - refactor `x1_layer_led` function as weak (#25668)
refactor `x1_layer_led` function as weak
| -rw-r--r-- | keyboards/binepad/knobx1/knobx1.c | 7 | ||||
| -rw-r--r-- | keyboards/binepad/knobx1/knobx1.h | 8 |
2 files changed, 8 insertions, 7 deletions
diff --git a/keyboards/binepad/knobx1/knobx1.c b/keyboards/binepad/knobx1/knobx1.c index 7f299b67e3..37602ca78c 100644 --- a/keyboards/binepad/knobx1/knobx1.c +++ b/keyboards/binepad/knobx1/knobx1.c @@ -9,6 +9,13 @@ # define X1_KEYMAP_LAYER_COUNT 4 #endif +__attribute__((weak)) void x1_layer_led(uint8_t lyr) { + gpio_write_pin(IND1_LED, lyr >= 0); + gpio_write_pin(IND2_LED, lyr >= 1); + gpio_write_pin(IND3_LED, lyr >= 2); + gpio_write_pin(IND4_LED, lyr >= 3); +} + void keyboard_pre_init_kb(void) { const pin_t indicator_leds[4] = {IND1_LED, IND2_LED, IND3_LED, IND4_LED}; for (int i = 0; i < 4; i++) { diff --git a/keyboards/binepad/knobx1/knobx1.h b/keyboards/binepad/knobx1/knobx1.h index 7645124057..3932fbd448 100644 --- a/keyboards/binepad/knobx1/knobx1.h +++ b/keyboards/binepad/knobx1/knobx1.h @@ -38,12 +38,6 @@ static inline void x1_led_3_off(void) { gpio_write_pin_low(IND3_LED); } static inline void x1_led_4_off(void) { gpio_write_pin_low(IND4_LED); } // clang-format on -static inline void x1_layer_led(uint8_t lyr) { - gpio_write_pin(IND1_LED, lyr >= 0); - gpio_write_pin(IND2_LED, lyr >= 1); - gpio_write_pin(IND3_LED, lyr >= 2); - gpio_write_pin(IND4_LED, lyr >= 3); -} - +void x1_layer_led(uint8_t lyr); bool process_x1_layer_up(keyrecord_t *record); bool process_x1_layer_down(keyrecord_t *record); |